This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: PATCH RFA: Fix simulator handling of floating point absolute value
- From: fche at redhat dot com (Frank Ch. Eigler)
- To: Ian Lance Taylor <ian at airs dot com>
- Cc: gdb-patches at sourceware dot org
- Date: 08 Jul 2005 11:38:10 -0400
- Subject: Re: PATCH RFA: Fix simulator handling of floating point absolute value
- References: <m3br5dx4ci.fsf@gossamer.airs.com>
ian wrote:
> [...]
> This patch changes sim_fpu_abs to always clear the sign bit of the
> argument. It does not otherwise change the behaviour. This, plus
> another patch I am about to sign, fixes the gcc copysign1 test for
> MIPS.
>
> OK for mainline?
> [...]
Looks okay. I can't find libgcc1 (soft-float emulation, the sim-fpu
code's ancestor) in current gcc any more to cross-check. Newlib's
fabs implementation (libm/math/s_fabs.c) appears to clear the sign bit
in the same way as your new code.
- FChE