This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFC] An initial patch for PR/1961
- From: Wu Zhou <woodzltc at cn dot ibm dot com>
- To: Daniel Jacobowitz <drow at false dot org>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Wed, 6 Jul 2005 15:20:37 +0800 (CST)
- Subject: Re: [RFC] An initial patch for PR/1961
- References: <Pine.LNX.4.63.0506182358130.2656@localhost.localdomain><20050703191243.GL13811@nevyn.them.org>
On Sun, 3 Jul 2005, Daniel Jacobowitz wrote:
> On Sun, Jun 19, 2005 at 12:02:14AM +0800, Wu Zhou wrote:
> > Hello all,
> >
> > I did some initial analysis against PR/1961 (Pls add a test for command
> > input of "-(" ). I found this SEGV error will also pop when issuing "+)",
> > "<)", ">(" and so on under gdbtui.
> >
> > My intial patch is attached as follows. Please review. Thanks.
> >
> > 2005-06-20 Wu Zhou <woodzltc@cn.ibm.com>
> >
> > * tui/tui-win.c (parse_scrolling_args): Fix SEGV error with invalid
> > scroll command.
>
> Please update the copyright year in this file. Otherwise, this patch
> is OK. Thanks!
Copyright year is updated and patch committed.
BTW. I ever thought of adding a testcase to verify this, but found that
gdb will timeout while waiting for the tui output under expect's control.
Is there any method to work around this? More generally, is there any way
to test TUI interface using expect? (I don't find any tests for TUI under
the testsuite directory.) Maybe it is desirable for TUI to receive enough
test just like what MI had done.
Just my two cents anyway. Comments are highly appreciated.
Cheers
- Wu Zhou