This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: PATCH: Start Fortran support for variable objects.
- From: Daniel Jacobowitz <drow at false dot org>
- To: Nick Roberts <nickrob at snap dot net dot nz>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Thu, 30 Jun 2005 09:18:09 -0400
- Subject: Re: PATCH: Start Fortran support for variable objects.
- References: <17091.4780.953681.620094@farnswood.snap.net.nz>
On Thu, Jun 30, 2005 at 09:29:16AM +1200, Nick Roberts wrote:
> ! vlang_unknown = 0, vlang_c, vlang_cplus, vlang_java, vlang_fortran,
> ! vlang_end
Extra space before vlang_fortran.
> java_value_of_variable}
> + ,
> + /* Fortran */
This style's wacky, but it's already in the file, so that's fine.
> --- 727,742 ----
> /* Mark as the end in case we bail out */
> *((*childlist) + i) = NULL;
>
> + if (variable_language (var) == vlang_fortran)
> + j = i + 1;
> + else
> + j = i;
> +
> /* check if child exists, if not create */
> ! name = name_of_child (var, j);
> child = child_exists (var, name);
> if (child == NULL)
> ! child = create_child (var, j, name);
>
> *((*childlist) + i) = child;
> }
Do you think you should use f77_get_dynamic_lowerbound? See eval.c,
under multi_f77_subscript.
--
Daniel Jacobowitz
CodeSourcery, LLC