This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] -stack-info-frames


On Mon, Jun 20, 2005 at 01:25:28PM +1200, Nick Roberts wrote:
>  > >  > > 1) mi_cmd_stack_info_frame uses print_frame_info instead of
>  > >  > >    print_stack_frame.  This follows mi_cmd_stack_list_frames and means
>  > >  > >    that the argument values aren't printed.
>  ...
> 
>  > > Which change?
>  > 
>  > #1.  Why not print the arguments?  I guess your logic is that if you
>  > want them, you can find them by a round trip through
>  > -stack-list-frames, is that it?
> 
> Well, through -stack-list-arguments (mi_cmd_stack_list_frames doesn't print
> arguments: I've used the same call to print_frame_info in -stack-info-frame).
> Also print_stack_frame calls eventually calls print_frame_info after a call to
> catch_errors, so it seemed more efficient.

OK, makes sense.  Thank you.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]