Re: [commit] gdb_byte regcache.[hc]

[Mark Kettenis <mark dot kettenis at xs4all dot nl>]

   Date: Sat, 11 Jun 2005 00:12:24 +0200 (CEST)
   From: Mark Kettenis <mark.kettenis@xs4all.nl>

      Date: Thu, 19 May 2005 13:24:08 -0400
      From: Andrew Cagney <cagney@gnu.org>

      2005-05-19  Andrew Cagney  <cagney@gnu.org>

	      * regcache.h (regcache_raw_read, regcache_raw_write)
	      (regcache_raw_read_part, regcache_raw_write_part)
	      (regcache_cooked_read_part, regcache_cooked_write_part)
	      (regcache_cooked_read, regcache_cooked_write)
	      (regcache_raw_supply, regcache_raw_collect)
	      (regcache_cooked_read_ftype, regcache_save, regcache_restore)
	      (deprecated_read_register_gen, deprecated_write_register_gen)
	      (deprecated_read_register_bytes, deprecated_write_register_bytes)
	      (deprecated_grub_regcache_for_registers): Use gdb_byte for byte
	      buffer parameters.
	      * ia64-tdep.c (ia64_extract_return_value): Update.
	      * frame.c (do_frame_register_read): Update.
	      * regcache.c (deprecated_grub_regcache_for_registers) 
	      (struct regcache, regcache_save, regcache_restore, regcache_cpy) 
	      (do_cooked_read, regcache_xmalloc, register_buffer) 
	      (deprecated_read_register_bytes, regcache_raw_read) 
	      (regcache_raw_read_signed, regcache_raw_read_unsigned) 
	      (deprecated_read_register_gen, regcache_cooked_read) 
	      (regcache_cooked_read_signed, regcache_cooked_read_unsigned) 
	      (deprecated_write_register_gen, regcache_cooked_write) 
	      (deprecated_write_register_bytes, regcache_raw_read_part) 
	      (regcache_raw_write_part, regcache_cooked_read_part) 
	      (regcache_cooked_write_part, read_register, regcache_raw_supply): 

   I know it's a bit late (just returned from vacation in .ca ;-), but
   there is a nasty problem with the register cache stuff in this patch
   :-(.  Many bits of native code pass native data types to
   regcache_raw_write, and this now raises a compiler warning.  I'm not
   sure how to solve this; adding casts all over the code is really,
   really ugly, and I really, really don't want to do that.  The best
   thing I can come up with is that we revert the regcache_raw_xxx
   interfaces back to using `void *', whereas we keep the
   regcache_cooked_xxx interface as they are now (using `gdb_byte *').

Argh, let's blame it on my jetlag, but I meant regcache_raw_supply and
regcache_raw_collect as the function that should take `void *' instead
of `gdb_byte *'.  The other regcache_raw_xxx functions can stay as
they are now.

Mark