This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] solib-svr4.c gdb_byteised.
- From: Daniel Jacobowitz <drow at false dot org>
- To: Manoj Iyer <manjo at austin dot ibm dot com>
- Cc: Kevin Buettner <kevinb at redhat dot com>, gdb-patches at sources dot redhat dot com
- Date: Mon, 6 Jun 2005 20:07:25 -0400
- Subject: Re: [PATCH] solib-svr4.c gdb_byteised.
- References: <Pine.LNX.4.58.0505261717060.13210@lazy> <20050603141436.1b8d24aa@ironwood.lan> <Pine.LNX.4.58.0506061715570.1519@lazy>
On Mon, Jun 06, 2005 at 05:17:08PM -0500, Manoj Iyer wrote:
>
> Just commited the following patch.
>
> 2005-06-06 Manoj Iyer <manjo@austin.ibm.com>
>
> * solib-svr4.c: Change type of 'lm' to gdb_byte.
> (elf_locate_base): Converted types of buf, bufend, pbuf, to gdb_byte.
> (first_link_map_member): Converted type of r_map_buf to gdb_byte.
> (open_symbol_file_object): Converted type of l_name_buf to gdb_byte.
> (svr4_fetch_objfile_link_map): Converted type of l_name_buf to
> gdb_byte.
FYI, please use the changelog entry as the CVS commit message in the
future. Also:
> > This patch is okay with me. Just fix the first line of your ChangeLog
> > entry as follows:
> >
> > * solib-svr4.c: (struct lm_info): Change type of ``lm'' to gdb_byte.
Both the version you used and Kevin's are wrong, Kevin picked up an
extra colon:
* solib-svr4.c (struct lm_info): Change type of ``lm'' to gdb_byte.
--
Daniel Jacobowitz
CodeSourcery, LLC