This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA/alpha] Use correct register for FP branches in alpha_next_pc()
- From: Daniel Jacobowitz <drow at false dot org>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sat, 28 May 2005 14:39:50 -0400
- Subject: Re: [RFA/alpha] Use correct register for FP branches in alpha_next_pc()
- References: <20050526063735.GL1530@adacore.com>
On Thu, May 26, 2005 at 04:37:35PM +1000, Joel Brobecker wrote:
> Blush... Obvious mistake ...
>
> I looked at the 18 failures I currently have when running the following
> testcase (not yet approved):
>
> http://sources.redhat.com/ml/gdb-patches/2005-05/msg00546.html
>
> It turns out it was an obvious confusion between the register number
> embedded in the instruction, and hte register number as GDB knows it.
> Say for instance we have a conditional branch instruction on f16, right
> now we read register number 16, which is register a0, not f16! The fix
> I just committed seemed to be improving things, but only by chance :-/.
> With the attached patch, all tests now PASS.
>
> 2005-05-26 Joel Brobecker <brobecker@adacore.com>
>
> * alpha-tdep.c (alpha_next_pc): Use correct register number
> for floating-point branch instructions.
>
> Tested on alpha-tru64 5.1a. No regression, fixes all 18 failures
> observed in alpha-step.exp.
>
> OK to apply?
This is OK.
--
Daniel Jacobowitz
CodeSourcery, LLC