Re: [patch] update gdb.base/gdb1555.exp to use new shared library infrastructure

[Paul Gilliam <pgilliam at us dot ibm dot com>]

I must get in a hurry, or something....

Please ignore the extra like in the ChangeLog portion of the patch.  I'll get rid of it.

On Thursday 28 April 2005 15:03, Paul Gilliam wrote:
> On Wednesday 27 April 2005 08:55, Daniel Jacobowitz wrote:
> > On Tue, Apr 19, 2005 at 04:31:05PM -0800, Paul Gilliam wrote:
> > > On Thursday 14 April 2005 12:20, Daniel Jacobowitz wrote:
> > > > On Wed, Apr 13, 2005 at 09:11:18AM -0800, Paul Gilliam wrote:
> > > > > This patch updates gdb.base/gdb1555.exp to use the new shared library infrastructure in
> > > > > lib/gdb.exp.  All the stuff that has been cut from shlib-call.exp is now part of 'gdb-compile'
> > > > > or 'gdb-compile-shlib' (new) in lib/gdb.exp.
> > > > > 
> > > > > This patch depends on the shared infrastructure patch:
> > > > >         http://sources.redhat.com/ml/gdb-patches/2005-04/msg00096.html
> > > > > 
> > > > > -=# Paul #=-
> > > > > 
> > > > > 2005-04-13  Paul Gilliam  <pgilliam@us.ibm.com>
> > > > > 
> > > > >         * gdb.base/gdb1555.exp: Change to use new shared library infrastructure and update
> > > > >         copyright date.
> > > > 
> > > > OK.  Same comment about the indentation of your '||' operators.  Also,
> > > > be sure to line wrap the ChangeLog for 80 columns.
> > > > 
> > > > 
> > > Here is the revised patch:
> > > 
> > > 2005-04-19  Paul Gilliam  <pgilliam@us.ibm.com>
> > > 
> > >         * gdb.base/gdb1555.exp: Change to use new shared library infrastructure
> > >         and update copyright date.
> > 
> > Two things: in the future, you don't need to mention updating the
> > copyright date in the changelog unless you're doing archeology. 
> > Researching missing years is a change worth documenting, adding the
> > current year should be automatic.  Also, the changelog is wrong for
> > this patch, since you didn't update the copyright date.  You should
> > have, though :-)
> > 
> 
> Don't know how I missed that....
> 
> Here is the new version, OK to commit?
> 
> =# Paul #=-
> ----
> 2005-04-19  Paul Gilliam  <pgilliam@us.ibm.com>
> 
> 	* gdb.base/gdb1555.exp: Change to use new shared library infrastructure.
>         and update copyright date. 
       ^^^^^^^^^^^^^^^^^^^^^ extra line, please ignore.   
>