This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFC] remote.c: Add remote TLS support
- From: "Eli Zaretskii" <eliz at gnu dot org>
- To: Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sat, 16 Apr 2005 12:09:07 +0300
- Subject: Re: [RFC] remote.c: Add remote TLS support
- References: <20050331162017.0e47552c@ironwood.lan> <20050415130913.50ee721c@ironwood.lan>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Fri, 15 Apr 2005 13:09:13 -0700
> From: Kevin Buettner <kevinb@redhat.com>
>
> I ended up deleting all calls to deprecated_show_value_hack(). As
> observed in other discussion, these calls were printing redundant
> information. I wish to thank Daniel Jacobowitz for reviewing these
> changes.
>
> With that out of the way, I ended up committing the following changes,
> only modified slightly from my earlier posting. (It no longer
> refers to the deprecated function and I removed some unused variables
> that were leftovers from an even earlier version of the work.)
>
> * remote.c (remote_protocol_qGetTLSAddr): New static global variable.
> (set_remote_protocol_qGetTLSAddr_packet_cmd)
> (show_remote_protocol_qGetTLSAddr_packet_cmd)
> (remote_get_thread_local_address): New functions.
> (init_all_packet_configs): Initialize remote_protocol_qGetTLSAddr
> variable.
> (init_remote_ops): Initialize ``to_get_thread_local_address'' in
> target vector.
> (show_remote_cmd): Call show_remote_protocol_qGetTLS_Addr_packet_cmd().
> (_initialize_remote): Register the following commands:
> "set remote get-thread-local-storage-address-packet" and
> "show remote get-thread-local-address-packet".
Thanks.
Please also add documentation for these new commands (in the "Remote
configuration" node).
I'd also like to ask everyone who approves patches to request that
each new command be accompanied by the appropriate patch for
gdb.texinfo. Ditto for a change in user-visible behavior of existing
commands. Let us not have undocumented features anymore!
TIA