This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Eliminate deprecated_show_value_hack from remote.c


On Fri, 15 Apr 2005 09:22:23 -0700
Kevin Buettner <kevinb@redhat.com> wrote:

> On Thu, 14 Apr 2005 15:37:57 -0400
> Daniel Jacobowitz <drow@false.org> wrote:
> 
> > On Wed, Apr 06, 2005 at 02:40:04PM -0700, Kevin Buettner wrote:
> > > Here's an update to my recently posted patch.  The only difference
> > > between it and my earlier patch is the addition of the word "packet"
> > > to the message printed by show_remote_protocol_packet_cmd().
> > > 
> > > 	* remote.c (show_remote_protocol_packet_cmd): New function.
> > > 	(show_remote_protocol_vcont_packet_cmd )
> > > 	(show_remote_protocol_qSymbol_packet_cmd)
> > > 	(show_remote_protocol_P_packet_cmd)
> > > 	(show_remote_protocol_Z_software_bp_packet_cmd)
> > > 	(show_remote_protocol_Z_hardware_bp_packet_cmd)
> > > 	(show_remote_protocol_Z_write_wp_packet_cmd)
> > > 	(show_remote_protocol_Z_read_wp_packet_cmd)
> > > 	(show_remote_protocol_Z_access_wp_packet_cmd)
> > > 	(show_remote_protocol_binary_download_cmd)
> > > 	(show_remote_protocol_qPart_auxv_packet_cmd)
> > > 	(show_remote_protocol_p_packet_cmd ): Replace calls to
> > > 	deprecated_show_value_hack() and show_packet_config_cmd()
> > > 	with single call to show_remote_protocol_packet_cmd().
> > 
> > Do you want to go ahead with this patch, or just remove the double
> > printing as discussed on gdb@?
> 
> The latter.  I'll prepare a new patch today.

Done.  The patch which removes the printing of redundant information
may be found here:

    http://sources.redhat.com/ml/gdb-patches/2005-04/msg00158.html

Since the new patch also eliminates the calls to
deprecated_show_value_hack(), the patches found in this thread (the
one I'm replying to) should be considered withdrawn.

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]