This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch] Allow altivec-{abi,regs}.c to be compiled by IBM's xlc compiler
- From: Paul Gilliam <pgilliam at us dot ibm dot com>
- To: Daniel Jacobowitz <drow at false dot org>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Wed, 30 Mar 2005 14:56:56 -0800
- Subject: Re: [patch] Allow altivec-{abi,regs}.c to be compiled by IBM's xlc compiler
- References: <200503091251.58836.pgilliam@us.ibm.com> <20050329204333.GB20646@nevyn.them.org>
- Reply-to: pgilliam at us dot ibm dot com
On Tuesday 29 March 2005 12:43, Daniel Jacobowitz wrote
> Warning takes a string. TCL doesn't use semicolons.
OK, I've fixed those two things (I don't know how I missed the type of
argument to 'warning') and have included the revised patch below.
-=# Paul #=-
PS: semicolons ARE used in TCL - as statement separators. Of course in this
case they are redundent, being followed by a new-line, the other statement
separator 8-)
2005-03-09 Paul Gilliam <pgilliam@us.ibm.com>
* gdb.arch/altivec-abi.exp: Check for compiler and set 'use altivec'
flag accordingly.
* gdb.arch/altivec-regs.exp: Likewise.
Index: gdb.arch/altivec-abi.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/altivec-abi.exp,v
retrieving revision 1.3
diff -c -3 -p -r1.3 altivec-abi.exp
*** gdb.arch/altivec-abi.exp 20 Jan 2003 15:40:07 -0000 1.3
--- gdb.arch/altivec-abi.exp 9 Mar 2005 19:25:34 -0000
*************** set testfile "altivec-abi"
*** 41,47 ****
set binfile ${objdir}/${subdir}/${testfile}
set srcfile ${testfile}.c
! if { [gdb_compile ${srcdir}/${subdir}/${srcfile} ${binfile} executable
{debug additional_flags=-w}] != "" } {
gdb_suppress_entire_file "Testcase compile failed, so all tests in this
file will automatically fail."
}
--- 41,62 ----
set binfile ${objdir}/${subdir}/${testfile}
set srcfile ${testfile}.c
! set compile_flags {debug additional_flags=-w}
! if [get_compiler_info $binfile] {
! warning "get_compiler failed"
! return -1
! }
!
! if [test_compiler_info gcc*] {
! set compile_flags "$compile_flags additional_flags=-maltivec"
! } elseif [test_compiler_info xlc*] {
! set compile_flags "$compile_flags additional_flags=-qaltivec"
! } else {
! warning "unknown compiler"
! return -1
! }
!
! if { [gdb_compile ${srcdir}/${subdir}/${srcfile} ${binfile} executable
$compile_flags] != "" } {
gdb_suppress_entire_file "Testcase compile failed, so all tests in this
file will automatically fail."
}
Index: gdb.arch/altivec-regs.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/altivec-regs.exp,v
retrieving revision 1.2
diff -c -3 -p -r1.2 altivec-regs.exp
*** gdb.arch/altivec-regs.exp 20 Jan 2003 15:40:07 -0000 1.2
--- gdb.arch/altivec-regs.exp 9 Mar 2005 19:25:34 -0000
*************** set testfile "altivec-regs"
*** 41,47 ****
set binfile ${objdir}/${subdir}/${testfile}
set srcfile ${testfile}.c
! if { [gdb_compile ${srcdir}/${subdir}/${srcfile} ${binfile} executable
{debug additional_flags=-w}] != "" } {
gdb_suppress_entire_file "Testcase compile failed, so all tests in this
file will automatically fail."
}
--- 41,62 ----
set binfile ${objdir}/${subdir}/${testfile}
set srcfile ${testfile}.c
! set compile_flags {debug additional_flags=-w}
! if [get_compiler_info $binfile] {
! warning "get_compiler failed"
! return -1
! }
!
! if [test_compiler_info gcc*] {
! set compile_flags "$compile_flags additional_flags=-maltivec"
! } elseif [test_compiler_info xlc*] {
! set compile_flags "$compile_flags additional_flags=-qaltivec"
! } else {
! warning "unknown compiler"
! return -1
! }
!
! if { [gdb_compile ${srcdir}/${subdir}/${srcfile} ${binfile} executable
$compile_flags] != "" } {
gdb_suppress_entire_file "Testcase compile failed, so all tests in this
file will automatically fail."
}