This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit] Ignore SEGVs from win32 IsBad* functions


> Date: Sun, 27 Mar 2005 10:43:40 -0500
> From: Daniel Jacobowitz <drow@false.org>
> Cc: gdb-patches@sourceware.org
> 
> > Nitpicking: won't it be cleaner to have a single string
> > "KERNEL32!IsBad", instead of mentioning it twice, and to use sizeof
> > instead of strlen?
> 
> The only thing this saves you is the chance of typos; recent GCC
> versions will not only combine the strings, but also fold strlen to a
> constant.

I know about these GCC features, but IMHO the code still looks cleaner
with the changes I suggested, and typos are not something we should
take too lightly.

(I did say I was nitpicking ;-)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]