This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Windows sockets


Christopher Faylor wrote:

I guess you could only check for the existence of ws2_32 when the host
is mingw, but that seems sort of redundant given that there is a
preprocessor test which precisely tells what needs to be done.

Right.


While
I'm normally a big fan of using conditionals like "HAVE_WINSOCK", it
doesn't seem like it makes the code any clearer to use these types of
conditionals in this case unless we really anticipate that there will
be another OS out there with some of the pecularities os Windows but
not all of them.

One observation is that maybe you could do something like:

#if defined (__WIN32__) && !defined (__CYGWIN__)
# define MINGW
#endif

and use #ifdef MINGW where appropriate.

If people would prefer that to WINAPI, that's fine by me.


(I'm not quite sure what we would call an environment in which the compiler was Visual C, or some other non-GCC Windows compiler. Would that still be MinGW? If not, then MINGW might not be as good a name, which is why I went with WINAPI. But, I'm not concerned about how to spell the conditional; whatever seems best to people is fine with me!)

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]