This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
I guess you could only check for the existence of ws2_32 when the host is mingw, but that seems sort of redundant given that there is a preprocessor test which precisely tells what needs to be done.
While I'm normally a big fan of using conditionals like "HAVE_WINSOCK", it doesn't seem like it makes the code any clearer to use these types of conditionals in this case unless we really anticipate that there will be another OS out there with some of the pecularities os Windows but not all of them.
One observation is that maybe you could do something like:
#if defined (__WIN32__) && !defined (__CYGWIN__) # define MINGW #endif
and use #ifdef MINGW where appropriate.
-- Mark Mitchell CodeSourcery, LLC mark@codesourcery.com (916) 791-8304
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |