This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Refactor ser-unix.c


Mark Kettenis wrote:

   In order to keep the patch easiser to read, I did not rename the
   ser-base.c routines with a ser_base prefix instead of the current
   ser_unix prefix, but I would like to make that change before
   check-in.

Yes, please; the ser_unix prefix doesn't really make sense for the
functions in set-base.c.  I presume is also makes sense to drop the
_nop_ in that operation.  You may check in this patch and than do the
rename in a seperate patch, or do it both at once.  Consider the
rename patch pre-approved.

I checked in the original patch, and will now work on the renaming patch.


Thanks,

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]