This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] gdbserver fails on 32-bit ppc rfs running in a-64 bit2.6 linux kernel


> > > > > > >> The strtoul change in my patch was already present. Sorry about that.
> > > > > > >> 
> > > > > > >> You have changed the data type of thread_resume::thread as well as cont_thread 
> > > > > > >> to unsigned long. "cont_thread = -1" and "(cont_thread > 0)" are still in 
> > > > > > >> place. How does this work?
> > > > 
> > > > There are about 15 files in gdb source have statement pid_to_ptid (-1);
> > > > which finally returns -1 to server. Is it OK to replace  -1 with 0 ? I
> > > > would like to know significance of returning pid -1, 0 and positive
> > > > integer.
> > > 
> whatever you need
> to change, you should be doing it only within gdbserver.  If you change
> GDB to fix a problem in gdbserver, you're changing the remote protocol.

Understood thanks. I believe that changing type of thread IDs to 'long
long' in gdbserver code will work. In that case I need to update all
places as you did it for changing type of thread IDs to 'unsigned long'
few days back. Is it the fix for this?

- Jitendra 



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]