This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: Add 'double' member to 64-bit vector register type


Daniel Jacobowitz <drow@false.org> writes:
> On Sat, Mar 19, 2005 at 01:13:15AM -0500, Jim Blandy wrote:
> > 
> > gdb/ChangeLog:
> > 2005-03-17  Jim Blandy  <jimb@redhat.com>
> > 
> > 	* gdbtypes.c (build_builtin_type_vec64): Include a 'double' member
> > 	in the union, too, since these registers can hold 64-bit floating
> > 	point types.
> 
> Rationale belongs in the patch mail or in comments, not in the
> changelog.

D'oh.  Thanks; I'll move it.

> I suppose you might as well, since no one but the e500 uses them.  But
> only some SPE processors support the double precision mode; do you
> really want to display the register as double on e500 v1?

Well, that brings up the other thought --- since the set of types
useful to include in a vector register really depends on the
architecture, wouldn't it be better to just export the convenience
functions for constructing these types from gdbtypes.c and then let
architectures build ones that actually suit their needs?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]