This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[ob] Warnings cleanup


Two warning fixes:
  - One overlooked pointer in the bfd_byte conversion, probably because this
    file uses -Wno-error.

  - dwarf_expr_tls_address always initializes addr; but you can't tell that
    without a way sophisticated interprocedural analysis of the exception
    handling machinery, so initialize it outside the TRY_CATCH.

Committed.

-- 
Daniel Jacobowitz
CodeSourcery, LLC

2005-03-19  Daniel Jacobowitz  <dan@codesourcery.com>

	* dwarf2loc.c (dwarf_expr_tls_address): Initialize ADDR.
	* gnu-v3-abi.c (gnuv3_baseclass_offset): Update type of
	VALADDR.

Index: dwarf2loc.c
===================================================================
RCS file: /big/fsf/rsync/src-cvs/src/gdb/dwarf2loc.c,v
retrieving revision 1.23
diff -u -p -r1.23 dwarf2loc.c
--- dwarf2loc.c	18 Mar 2005 21:03:39 -0000	1.23
+++ dwarf2loc.c	19 Mar 2005 19:29:45 -0000
@@ -186,7 +186,7 @@ static CORE_ADDR
 dwarf_expr_tls_address (void *baton, CORE_ADDR offset)
 {
   struct dwarf_expr_baton *debaton = (struct dwarf_expr_baton *) baton;
-  CORE_ADDR addr;
+  CORE_ADDR addr = 0;
 
   if (target_get_thread_local_address_p ())
     {
Index: gnu-v3-abi.c
===================================================================
RCS file: /big/fsf/rsync/src-cvs/src/gdb/gnu-v3-abi.c,v
retrieving revision 1.26
diff -u -p -r1.26 gnu-v3-abi.c
--- gnu-v3-abi.c	11 Feb 2005 04:05:50 -0000	1.26
+++ gnu-v3-abi.c	19 Mar 2005 19:30:31 -0000
@@ -355,7 +355,7 @@ gnuv3_virtual_fn_field (struct value **v
 
    -1 is returned on error. */
 static int
-gnuv3_baseclass_offset (struct type *type, int index, char *valaddr,
+gnuv3_baseclass_offset (struct type *type, int index, const bfd_byte *valaddr,
 			CORE_ADDR address)
 {
   struct type *vtable_type = gdbarch_data (current_gdbarch,


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]