This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Broken logic in dwarf_reg_to_regnum


Patch below fixes a typo in {amd64,s390}_dwarf_reg_to_regnum.

Applied as obvious.

Paul

2005-03-17  Paul Brook  <paul@codesourcery.com>

 * amd64-tdep.c (amd64_dwarf_reg_to_regnum): Fix broken logic.
 * s390-tdep.c (s390_dwarf_reg_to_regnum): Ditto.

Index: amd64-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/amd64-tdep.c,v
retrieving revision 1.21
diff -u -p -r1.21 amd64-tdep.c
--- amd64-tdep.c 11 Feb 2005 04:05:43 -0000 1.21
+++ amd64-tdep.c 17 Mar 2005 17:35:34 -0000
@@ -200,7 +200,7 @@ amd64_dwarf_reg_to_regnum (int reg)
 {
   int regnum = -1;
 
-  if (reg >= 0 || reg < amd64_dwarf_regmap_len)
+  if (reg >= 0 && reg < amd64_dwarf_regmap_len)
     regnum = amd64_dwarf_regmap[reg];
 
   if (regnum == -1)
Index: s390-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/s390-tdep.c,v
retrieving revision 1.141
diff -u -p -r1.141 s390-tdep.c
--- s390-tdep.c 11 Feb 2005 18:13:52 -0000 1.141
+++ s390-tdep.c 17 Mar 2005 17:35:35 -0000
@@ -197,7 +197,7 @@ s390_dwarf_reg_to_regnum (int reg)
 {
   int regnum = -1;
 
-  if (reg >= 0 || reg < ARRAY_SIZE (s390_dwarf_regmap))
+  if (reg >= 0 && reg < ARRAY_SIZE (s390_dwarf_regmap))
     regnum = s390_dwarf_regmap[reg];
 
   if (regnum == -1)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]