This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] gdbserver fails on 32-bit ppc rfs running in a-64 bit 2.6 linux kernel


On Tue, Mar 15, 2005 at 06:36:22PM +0530, Amit S. Kale wrote:
> The strtoul change in my patch was already present. Sorry about that.
> 
> You have changed the data type of thread_resume::thread as well as cont_thread 
> to unsigned long. "cont_thread = -1" and "(cont_thread > 0)" are still in 
> place. How does this work?

Hmm, looks like you found a real problem here; would you like to fix
it?  Modern GDBs don't heavily use this code, because of the vCont
packet.  Otherwise I'll fix it, but I may not find time for a bit.

> Can we use a thread value of "0" to indicate all threads or no-thread instead 
> of "-1"? The condition "cont_thread > 0" becomes valid if we do that.

This value can be set from the remote protocol, so we would have to
transform it in Hc/Hg support also.


-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]