This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Don't use -Wuninitialized if CFLAGS omits -O


Joel Brobecker <brobecker@adacore.com> writes:

> > > I think there is a slight problem that broke the build with non-GNU
> > > bourne shells. We have a build failure on our solaris 2.8 machine,
> > > for instance. Here is what I think the problem is:
> > > 
> > > > + # GCC supports -Wuninitialized only with -O or -On, n != 0.
> > > > + if test x${CFLAGS+set} == xset; then
> > >                            ^^
> > > I think the "==" should be "=", no? That's what "man test" documents.
> > > But I've never been a shell guru...
> > 
> > Yes, that's right.  Would you mind fixing this?
> 
> Sure, wildo later today.

Beat you to it.  Sorry about that.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]