This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] gdb.base/float.exp and gdb.base/commands.exp patch


On Mon, Mar 07, 2005 at 10:39:32AM -0600, Manoj Iyer wrote:
> >
> > Accepting any line number is not OK.  Accepting this particular line
> > number does seem plausible.  Can you do that instead?
> >
> 
> If I change the current value of 57 to 82, the test will pass in powerpc
> but fail on intel. Coz the generated line numbers on intel(57) and
> PowerPC(82) are different.

That's why you should accept both of them.

> > I've done it in the past.  It's not that hard to get ahold of one.
> > But, as I said, I do not know what will be output.
> > Might as well do this for now and fix it up later.
> >
> 
> So, does that mean you accept the patch to float.exp? Or are we still
> worried about ppc32 nofpu?

I think it's OK.  Please post the patch + changelog for just float.exp,
and check that in.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]