This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA:] Support lstat as simulator call.


Hans-Peter Nilsson wrote:
Date: Tue, 7 Dec 2004 02:43:16 +0100
From: Hans-Peter Nilsson <hp@axis.com>

Yes (with tweak) and thanks for testing this.


callback.c 3 Dec 2004 23:34:55 -0000 1.12
--- callback.c 6 Dec 2004 17:10:25 -0000
*************** os_fstat (p, fd, buf)
*** 407,412 ****
--- 407,422 ----
return wrap (p, fstat (fdmap (p, fd), buf));
}
+ static int
+ os_lstat (p, file, buf)
+ host_callback *p;
+ const char *file;
+ struct stat *buf;
+ {
+ /* ??? Same issue here as with os_fstat. */

Use /* FIXME: hpn/2004-12-12: ... */ or /* NOTE: hph/2004-12-12: ... */ so we know who and when the comment was added.


therwize, yes, ok,
Andrew

+ return (p, lstat (file, buf));


Oops should have been "return wrap (p, lstat (file, buf));"
Sorry about that.

(Noticed because of a error-checking test-case that didn't show
up as KPASS...  The local equivalent had sysroot stuff here so
the code was slightly edited from the well-tested variant.)

brgds, H-P



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]