This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA/RFC/IRIX] Remove some deprecated_registers from irix5-nat.c


Hello,

Here is a patch that removes most of the uses of deprecated_registers
in irix5-nat.c. I am not too familiar with the regcache yet, I hope
I got it right. There was also a small issue with type size, where
I introduced a temporary (regval) to make sure that the buffer given
to regcache_raw_read_signed would always be large enough. Not sure
whether it was the best way to do it (this shows my lack of C knowledge).

2004-11-13  Joel Brobecker  <brobecker@gnat.com>

        * irix5-nat.c (fill_gregset): Replace use of deprecated_registers
        with equivalent code.
        (fill_fpregset): Likewise.

Tested on mips-irix. There is an occasional screwup during the execution
of gdb.threads/killed.exp that causes the testsuite to abort before the
end:

        ERROR: (DejaGnu) proc "(gdb) {$}" does not exist.
        The error code is NONE
        The info on the error is:
        close: invalid spawn id (8)
            while executing
        "close -i 8"
            invoked from within
        "catch "close -i $spawn_id""

Given that the testsuite takes a fair bit of time to run on our
IRIX machine, and given that it can happen several times in a row
before I get a clean run, I am reluctant to retry.

So it's a bit more difficult to compare the two testsuite results.
But I verified that we didn't have any change in all the testsuite
up until this point.

OK to apply?

The last couple of uses of deprecated_registers will be removed shortly.
I decided to handle them separately because they are used when loading
the registers from a core file. I wanted to evaluate the attached change
first.

Thanks,
-- 
Joel

Attachment: irix5-nat.c.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]