Re: [commit] Add add_setshow_enum_cmd, use in mips

["Eli Zaretskii" <eliz at gnu dot org>]

> Date: Wed, 10 Nov 2004 22:42:14 +0100 (CET)
> From: Mark Kettenis <mark.kettenis@xs4all.nl>
> CC: cagney@gnu.org, drow@false.org, gdb-patches@sources.redhat.com
> 
> Sorry, but I have to disagree here.  For the (unfortunately) limited
> number of people that contribute several patches in a week this is a
> significant problem.  When I'm working on a particular area I often
> find myself making multiple changes to the same file.  If I have to
> post a patch and wait a week before I can check it in, I have two
> options:
> 
> 1. Juggle with the patches for a week, risking an accidental commit of
>    stuff belonging to a different patch to the same file, or dropping
>    a patch completely in the process.
> 
> 2. Postpone further work on that part of GDB until the week is over
>    and the patch has been committed.
> 
> Neither option is good for GDB.

That might be tough, but we all do precisely that when the file in
question is not in our maintainership area.

Mind you, I'm not suggesting that you should post an RFA in x86 files,
as you are the area maintainer for those.  I'm talking about files for
which there's no area maintainer.  The idea being that we are all
collectively responsible for such files, so the patch should be
approved collectively rather than unilaterally.

Yes, it slows down the development a bit, but I don't think the patch
rate is our most important goal.  The rate is important, but code
quality and clean design are IMHO more important.