This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit] Add add_setshow_enum_cmd, use in mips


This whole thread is stupid.

Before committing a patch as I did, I ask the question:

``Could a review significantly alter the change?''

Conversely, when reviewing a change, I ask:

``Is the objection going to significantly alter the change?''

Here, I cloned a pre-existing interface, adding another variant. Anyone on this list with the problem I hit would have come up with an identical change.

Waiting a week would have achieved what?

Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]