This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[RFA:] Fix missing dependencies for sim-load.o
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Tue, 9 Nov 2004 14:38:45 +0100
- Subject: [RFA:] Fix missing dependencies for sim-load.o
If you look at sim-load.c, you'll see #includes of
gdb/remote-sim.h, sim-basics.h and sim-utils.h, not just
$(callback_h). I don't see sim-basics.h mentioned in
dependencide anywhere else than sim_main_headers, so that seems
an appropriate dependency.
Also, though a grep reveals
sim-basics.h:150:#include "sim-utils.h"
sim-hload.c:23:#include "sim-utils.h"
sim-load.c:39:#include "sim-utils.h"
sim-utils.c:50:#include "sim-utils.h"
I don't see sim-utils.h mentioned in any dependency in
Make-common.in. Best seems to add it to sim_main_headers.
Spotted by coincidence; no other dependencies checked for
similar problems.
Ok to commit?
2004-11-09 Hans-Peter Nilsson <hp@axis.com>
* Make-common.in (sim-load.o): Depend on $(sim_main_headers) and
$(remote_sim_h) too.
(sim_main_headers): Add sim-utils.h.
Index: Make-common.in
===================================================================
RCS file: /cvs/src/src/sim/common/Make-common.in,v
retrieving revision 1.13
diff -c -p -r1.13 Make-common.in
*** Make-common.in 8 Sep 2003 17:24:59 -0000 1.13
--- Make-common.in 9 Nov 2004 13:26:27 -0000
*************** sim_main_headers = \
*** 312,317 ****
--- 312,318 ----
$(srccom)/sim-profile.h \
$(srccom)/sim-signal.h \
$(srccom)/sim-trace.h \
+ $(srccom)/sim-utils.h \
$(srccom)/sim-watch.h \
tconfig.h \
$(SIM_EXTRA_DEPS)
*************** sim-utils.o: $(srccom)/sim-utils.c $(sim
*** 472,478 ****
sim-watch.o: $(srccom)/sim-watch.c $(sim_main_headers)
$(CC) -c $(srccom)/sim-watch.c $(ALL_CFLAGS)
! sim-load.o: $(srccom)/sim-load.c $(callback_h)
$(CC) -c $(srccom)/sim-load.c $(ALL_CFLAGS)
--- 473,479 ----
sim-watch.o: $(srccom)/sim-watch.c $(sim_main_headers)
$(CC) -c $(srccom)/sim-watch.c $(ALL_CFLAGS)
! sim-load.o: $(srccom)/sim-load.c $(callback_h) $(sim_main_headers) $(remote_sim_h)
$(CC) -c $(srccom)/sim-load.c $(ALL_CFLAGS)
brgds, H-P