This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] dwarf2read.c: Use make_function_type instead of lookup_function_type
- From: Jim Blandy <jimb at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: 05 Oct 2004 11:41:11 -0500
- Subject: Re: [RFA] dwarf2read.c: Use make_function_type instead of lookup_function_type
- References: <20041005162205.GA31478@cygbert.vinschen.de>
Corinna Vinschen <vinschen@redhat.com> writes:
> the below patch uses make_function_type instead of lookup_function_type
> in read_subroutine_type. The reason is that it's important that `ftype'
> is a new type structure for each function and so it shouldn't get reused
> by other function types. The comment for lookup_function_type indicates
> that it's made to do exactly that, reusing already existing function
> types as they fit. That's not implemented so far, but it might happen
> at one point, so I suggest to switch to make_function_type in
> read_subroutine_type before something weird happens.
>
> Ok to check in?
>
>
> Corinna
>
> * dwarf2read.c (read_subroutine_type): Call make_function_type
> instead of lookup_function_type.
This looks fine. Thanks!