Re: [RFC] Suggested ways to remove the need for xm-go32.h

[Christopher Faylor <me at cgf dot cx>]

On Thu, Sep 23, 2004 at 10:58:17PM +0200, Mark Kettenis wrote:
>   Date: Thu, 23 Sep 2004 01:05:34 -0400
>   From: Christopher Faylor <me@cgf.cx>
>
>   On Sat, Sep 18, 2004 at 04:18:31PM +0300, Eli Zaretskii wrote:
>   >Here's how I propose to deal with each one of these:
>   >
>   >1.  fopen-bin.h: I suggest to modify the default definitions of the
>   >    FOPEN_* macros on defs.h to the ANSI/ISO-compatible "rb", "wb",
>   >    etc. strings that include the "b" modifier.  Since we already
>   >    require ISO C compliance from all the ports, such a default must
>   >    DTRT.  Once the defaults are changed, there should be no need to
>   >    use fopen-bin.h neither in the DJGPP nor in the Cygwin port.
>
>   I'd be happy to see this but I see that later in the thread that we
>   seem to be converging on a wrapper function.
>
>I still favour the wrapper function, since that's more robust, but I
>wouldn't really object if we'd use exactly the same configure magic as
>BFD does.  Note that that imposes a burden on the maintainers of
>DOS-ish systems to keep it in sync with BFD.

i.e.,

  dnl See whether we need to use fopen-bin.h rather than fopen-same.h.
  AC_DEFUN([BFD_BINARY_FOPEN],
  [AC_REQUIRE([AC_CANONICAL_SYSTEM])
  case "${host}" in
  changequote(,)dnl
  *-*-msdos* | *-*-go32* | *-*-mingw32* | *-*-cygwin* | *-*-windows*)
  changequote([,])dnl
    AC_DEFINE(USE_BINARY_FOPEN, 1, [Use b modifier when opening binary files?]) ;;
  esac])dnl

Since I've never had to worry about this in binutils, it's probably ok
but, these days, I think it's backwards to put the burden on the
maintainers of the modern systems (i.e., cygwin and DJGPP) at the
expense of the hypothetical ancient ones.  Why not let the Ultrix
maintainer worry about this rather than the cygwin/djgpp maintainers?

>   >4.  DIRNAME_SEPARATOR: The DOS-specific definition can be put either
>   >    in defs.h or local to the only file that uses it (source.c).
>
>   This could be determined at configure time couldn't it?  You could
>   play with the path to see if a colon or semicolon does the desired
>   thing and then set it appropriately via config.in.
>
>Please note that DIRNAME_SEPARATOR is only used in GDB.  Preferably it
>would be the same on all hosts, although it makes sense to follow the
>convention of the host platform if there is one.  That's why we have
>':' on POSIX-ish systems.  The most important reasone why it's
>something different on DOS-ish systems, is that ':' is to specify
>drive letters and therefore useless as a sepatator.  Makes me wonder
>why cygwin uses ':'.

Cygwin is a POSIX emulation and it should be using the same thing as
UNIX.  You can actually use colons (and semicolons for that matter) in
file names in Cygwin, depending on the mount option.

A simple way to see what the preference is would be to poll the PATH
environment variable.  But, then, it's easy enough to must make it ';'
for the one host that needs it by using a similar technique to the
above.

cgf