Re: [PATCH] Fixes testsuit/gdb.base/annota1.exp

[Michael Chastain <mec dot gnu at mindspring dot com>]

This is good work.  Here's my nit-picking.  The main issue is
generating backtrace.c versus a static file.

Michael

. ChangeLog entry

. Drop the "Please email any bugs, comments, ..." inside the file.

. It's elegant to generate the C program, but there are a couple of
  problems.  You're writing on the source tree which screws up people
  who run multiple test runs out of the same source tree simultaneously.
  And all the external calls need error checking.  And there is a
  copyright notice in backtrace.c, but no license.

  Just drop the generation and supply backtrace.c like a normal file.
  That loses the ability to change subr_depth easily, but that's okay.

. subr_depth is still cool, you just have to document that it has to
  match backtrace.c.