This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] patch to remove language-dependent numeric output support


On Fri, Sep 10, 2004 at 07:40:32PM -0700, Paul Hilfinger wrote:


> Just some notes though:
> > (local_decimal_format_custom): Remove.
> >
> > * utils.c: (int_string): New function.
> I suspect that the the blank lines aren't needed - blank lines separate > commits rather than separate parts of the same commit - whichever.


Really?  OK.  Actually, I was putting in blank lines just to break up
a long ChangeLog entry, but if there's actually a convention, I'm
happy to follow it.

Near enough. Here's the exact text: http://www.gnu.org/prep/standards_42.html#SEC42
Separate unrelated change log entries with blank lines. When two entries represent parts of the same change, so that they work together, then don't put blank lines between them. Then you can omit the file name and the asterisk when successive entries are in the same file.


FWIW, I've always used blank lines to separate logically distinct
portions of a changelog entry.  I have no idea what the actual
convention is :-)

Or this. It has the same effect - we never combine logically distinct changes into a single commit.


Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]