This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA]: Fix for pending breakpoints in manually loaded/unloaded shlibs


Okay, here's a patch for unload.exp to make it work on hpux 11.11.
I tested it on hpux 11.11 with both hp ansi c B.11.11.28706.GP and
gcc 3.3.4.  I didn't test it on any linux.

It will be easy to add more arms to the "switch" statement
as it gets tested on more operating systems.

Can you:

  throw this chunk in
  rip out the old bug-gdb address
  rip out the "-L" / "-rpath" leftovers (see below)
  re-test on i686-pc-linux-gnu
  re-post the patch (mention that you re-tested on i686-pc-linux-gnu)

Right before gdb_exit there is a chunk of code to set "-L" or "-rpath".
It looks dead because these values are never used after being set.
Can you rip that out?  Sorry I didn't catch that earlier.

Then I will re-test on native hppa2.0w-hp-hpux11.11 and that ought
to be good for approval.

Michael C

--- /house/chastain/u/unload.exp	2004-08-12 07:32:11.268088000 -0400
+++ unload.exp	2004-08-12 09:09:43.989638000 -0400
@@ -48,7 +48,14 @@
     return -1
 }
 
-if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [list debug "additional_flags=-DSHLIB_DIR\=\"${shlibdir}\"" "libs=-ldl"]] != "" } {
+set dl_lib_flag ""
+switch -glob [istarget] {
+    "hppa*-hp-hpux*" { }
+    "*-*-linux*"     { set dl_lib_flag "libs=-ldl" }
+    default          { }
+}
+
+if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [list debug "additional_flags=-DSHLIB_DIR\=\"${shlibdir}\"" $dl_lib_flag]] != "" } {
      gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail."
 }
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]