This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa] Cleanup store.exp
- From: Michael Chastain <mec dot gnu at mindspring dot com>
- To: gdb-patches at sources dot redhat dot com, cagney at gnu dot org
- Date: Wed, 04 Aug 2004 00:10:03 -0400
- Subject: Re: [rfa] Cleanup store.exp
- References: <411040EB.3060904@gnu.org>
Andrew Cagney <cagney@gnu.org> wrote:
> This gets rid of the duplicate test messages in sore.exp. Tested on FC2.
> m'kay.
This patch is approved.
I'm particularly happy with this bit:
- gdb_test "print l" " = ${l}" "print old l - ${t}"
- gdb_test "print r" " = ${r}" "print old r - ${t}"
+ gdb_test "print l" " = ${l}" \
+ "${prefix}; print old l, expecting ${l}"
+ gdb_test "print r" " = ${r}" \
+ "${prefix}; print old r, expecting ${r}"
Maybe it's just me, but when I saw "print old l - int",
I parsed it as "print old l minus int". So I'm glad to see
the dash character go away.
Michael C
===
2004-08-03 Andrew Cagney <cagney@gnu.org>
* gdb.base/store.exp: Update copyright.
(check_set, up_set, check_struct, up_struct): Add a prefix to test
names, do not import gdb_prompt.