This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commited] small changes to fix hpux-cc compile


> The question should be: will there ever be a target that uses SOM that
> doesn't use 32-bit ints?  I think we can be fairly certain that there
> won't be such target in the future.  HP already has abandoned SOM in
> favour of ELF of 64-bit HP-UX, and even that still has 32-bit ints.
> As a matter of fact, I'm not aware of any ABI that has 64-bit ints.

Yes, this was indeed my thinking and why i hardcoded it.

> But in general:
> 
>    How about this instead:
> 
>      char * dld_flags_buffer = alloca(TARGET_INT_BIT/TARGET_CHAR_BIT);
> 
> This is indeed the right approach.

actually in the code:

  unsigned int dld_flags_value;
[...]
  dld_flags_value = extract_unsigned_integer (dld_flags_buffer,
                                              sizeof (dld_flags_value));

so the code does not anyway allow dld_flags_value to be 64-bit. (i don't
think anyone ever does 64-bit int's, right?)

randolph
-- 
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]