This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Fix small problems in rs6000-tdep.c:skip_prologue()
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Joel Brobecker <brobecker at gnat dot com>
- Cc: Jim Blandy <jimb at redhat dot com>, gdb-patches at sources dot redhat dot com
- Date: Fri, 14 May 2004 17:05:39 -0700
- Subject: Re: [RFA] Fix small problems in rs6000-tdep.c:skip_prologue()
- Organization: Red Hat
- References: <20040402183637.GC871@gnat.com><vt2u1026q1j.fsf@zenia.home><20040417051545.GO22414@gnat.com><20040508001600.GH16083@gnat.com><vt2r7tmlkjs.fsf@zenia.home>
On 14 May 2004 17:18:31 -0500
Jim Blandy <jimb@redhat.com> wrote:
> > > Attached is a revised version incorporating your changes. Could you
> > > give it a shot against your function, and let me know if it works for
> > > you? It works for me, and doesn't introduce any regression on our
> > > powerpc-aix-5.1 machine.
> > >
> > > 2004-04-16 Joel Brobecker <brobecker@gnat.com>
> > >
> > > * rs6000-tdep.c (store_param_on_stack_p): New function,
> > > an improved version of some code extracted from skip_prologue().
> > > (skip_prologue): Use store_param_on_stack_p() to detect
> > > instructions saving a parameter on the stack. Detect when r0
> > > is used to save a parameter.
> > > Do not mark "li rx, SIMM" instructions as part of the prologue,
> > > unless the following instruction is also part of the prologue.
> > >
> > > I'll followup with a testcase soon.
>
> I've finally been able to give this a shot, and it works fine on my
> prologue, too. So I have no objections to the patch. Thanks for your
> patience, Joel!
Joel, your revised patch is approved.
Kevin