This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[ob] Garbage collect step_sp
- From: Andrew Cagney <cagney at gnu dot org>
- To: gdb-patches at sources dot redhat dot com
- Date: Wed, 12 May 2004 18:19:47 -0400
- Subject: [ob] Garbage collect step_sp
The value is no longer used, committed.
Andrew
2004-05-12 Andrew Cagney <cagney@redhat.com>
* thread.c (load_infrun_state): Delete step_sp.
* infrun.c (context_switch): Ditto.
* inferior.h (step_sp): Ditto.
* infcmd.c (step_sp, step_1, step_once, until_next_command): Ditto.
* gdbthread.h (struct thread_info, save_infrun_state)
(restore_infrun_state): Ditto.
Index: gdbthread.h
===================================================================
RCS file: /cvs/src/src/gdb/gdbthread.h,v
retrieving revision 1.10
diff -p -u -r1.10 gdbthread.h
--- gdbthread.h 10 May 2004 23:27:49 -0000 1.10
+++ gdbthread.h 12 May 2004 22:18:01 -0000
@@ -48,7 +48,6 @@ struct thread_info
CORE_ADDR step_range_start;
CORE_ADDR step_range_end;
struct frame_id step_frame_id;
- CORE_ADDR step_sp;
int current_line;
struct symtab *current_symtab;
int trap_expected;
@@ -126,8 +125,7 @@ extern void save_infrun_state (ptid_t pt
bpstat stepping_through_solib_catchpoints,
int stepping_through_sigtramp,
int current_line,
- struct symtab *current_symtab,
- CORE_ADDR step_sp);
+ struct symtab *current_symtab);
/* infrun context switch: load the debugger state previously saved
for the given thread. */
@@ -144,8 +142,7 @@ extern void load_infrun_state (ptid_t pt
bpstat *stepping_through_solib_catchpoints,
int *stepping_through_sigtramp,
int *current_line,
- struct symtab **current_symtab,
- CORE_ADDR *step_sp);
+ struct symtab **current_symtab);
/* Commands with a prefix of `thread'. */
extern struct cmd_list_element *thread_cmd_list;
Index: infcmd.c
===================================================================
RCS file: /cvs/src/src/gdb/infcmd.c,v
retrieving revision 1.110
diff -p -u -r1.110 infcmd.c
--- infcmd.c 12 May 2004 18:08:38 -0000 1.110
+++ infcmd.c 12 May 2004 22:18:02 -0000
@@ -186,11 +186,6 @@ CORE_ADDR step_range_end; /* Exclusive *
struct frame_id step_frame_id;
-/* Our notion of the current stack pointer. */
-/* NOTE: cagney/2004-05-09: This variable is not used and should be
- garbage collected. */
-CORE_ADDR step_sp;
-
enum step_over_calls_kind step_over_calls;
/* If stepping, nonzero means step count is > 1
@@ -625,7 +620,6 @@ step_1 (int skip_subroutines, int single
if (!frame) /* Avoid coredump here. Why tho? */
error ("No current frame");
step_frame_id = get_frame_id (frame);
- step_sp = read_sp ();
if (!single_inst)
{
@@ -725,7 +719,6 @@ step_once (int skip_subroutines, int sin
if (!frame) /* Avoid coredump here. Why tho? */
error ("No current frame");
step_frame_id = get_frame_id (frame);
- step_sp = read_sp ();
if (!single_inst)
{
@@ -978,7 +971,6 @@ until_next_command (int from_tty)
step_over_calls = STEP_OVER_ALL;
step_frame_id = get_frame_id (frame);
- step_sp = read_sp ();
step_multi = 0; /* Only one call to proceed */
Index: inferior.h
===================================================================
RCS file: /cvs/src/src/gdb/inferior.h,v
retrieving revision 1.64
diff -p -u -r1.64 inferior.h
--- inferior.h 8 May 2004 20:48:52 -0000 1.64
+++ inferior.h 12 May 2004 22:18:02 -0000
@@ -364,10 +364,6 @@ extern CORE_ADDR step_range_end; /* Excl
extern struct frame_id step_frame_id;
-/* Our notion of the current stack pointer. */
-
-extern CORE_ADDR step_sp;
-
/* 1 means step over all subroutine calls.
-1 means step over calls to undebuggable functions. */
Index: infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.157
diff -p -u -r1.157 infrun.c
--- infrun.c 12 May 2004 18:08:38 -0000 1.157
+++ infrun.c 12 May 2004 22:18:02 -0000
@@ -1159,7 +1159,7 @@ context_switch (struct execution_control
ecs->stepping_through_solib_after_catch,
ecs->stepping_through_solib_catchpoints,
ecs->stepping_through_sigtramp,
- ecs->current_line, ecs->current_symtab, step_sp);
+ ecs->current_line, ecs->current_symtab);
/* Load infrun state for the new thread. */
load_infrun_state (ecs->ptid, &prev_pc,
@@ -1170,7 +1170,7 @@ context_switch (struct execution_control
&ecs->stepping_through_solib_after_catch,
&ecs->stepping_through_solib_catchpoints,
&ecs->stepping_through_sigtramp,
- &ecs->current_line, &ecs->current_symtab, &step_sp);
+ &ecs->current_line, &ecs->current_symtab);
}
inferior_ptid = ecs->ptid;
}
Index: thread.c
===================================================================
RCS file: /cvs/src/src/gdb/thread.c,v
retrieving revision 1.35
diff -p -u -r1.35 thread.c
--- thread.c 10 May 2004 23:27:49 -0000 1.35
+++ thread.c 12 May 2004 22:18:02 -0000
@@ -303,7 +303,7 @@ load_infrun_state (ptid_t ptid,
bpstat *stepping_through_solib_catchpoints,
int *stepping_through_sigtramp,
int *current_line,
- struct symtab **current_symtab, CORE_ADDR *step_sp)
+ struct symtab **current_symtab)
{
struct thread_info *tp;
@@ -328,7 +328,6 @@ load_infrun_state (ptid_t ptid,
*stepping_through_sigtramp = tp->stepping_through_sigtramp;
*current_line = tp->current_line;
*current_symtab = tp->current_symtab;
- *step_sp = tp->step_sp;
}
/* Save infrun state for the thread PID. */
@@ -347,7 +346,7 @@ save_infrun_state (ptid_t ptid,
bpstat stepping_through_solib_catchpoints,
int stepping_through_sigtramp,
int current_line,
- struct symtab *current_symtab, CORE_ADDR step_sp)
+ struct symtab *current_symtab)
{
struct thread_info *tp;
@@ -370,7 +369,6 @@ save_infrun_state (ptid_t ptid,
tp->stepping_through_sigtramp = stepping_through_sigtramp;
tp->current_line = current_line;
tp->current_symtab = current_symtab;
- tp->step_sp = step_sp;
}
/* Return true if TP is an active thread. */