This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] use CFLAGS when compiling (PPC64)
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: Andrew Cagney <cagney at gnu dot org>
- Cc: Manoj Iyer <manjo at austin dot ibm dot com>, gdb-patches at sources dot redhat dot com
- Date: Thu, 29 Apr 2004 17:12:37 -0400
- Subject: Re: [PATCH] use CFLAGS when compiling (PPC64)
- References: <Pine.LNX.4.58.0404071458500.9321@lazy> <40912759.1080706@gnu.org>
On Thu, Apr 29, 2004 at 12:03:37PM -0400, Andrew Cagney wrote:
> >This patch add CFLAGS to the compile line for building gdbserver,
> >gdbreplay and tclsh. Compiling GDB as 64bit binary on PPC64 breaks without
> >this.
>
> Daniel, did this get rejected? I recall it being pointed out that the
> correct way to build such a beastie was with:
>
> CC='gcc -m64' ./configure && gmake
>
> and I know that already works.
It wasn't rejected but I think it should be. It seems reasonable, but
if something needs to be added to link command lines, it should be in
$CC or in $LDFLAGS. I don't know what the GNU coding standards have to
say about that, though - just my opinion.
> >diff -Naurd old/src/gdb/gdbserver/Makefile.in
> >new/src/gdb/gdbserver/Makefile.in
> >--- old/src/gdb/gdbserver/Makefile.in 2004-03-04 16:59:10.000000000 -0500
> >+++ new/src/gdb/gdbserver/Makefile.in 2004-04-07 15:04:06.398979032 -0500
> >@@ -171,12 +171,12 @@
> >
> > gdbserver: $(OBS) ${ADD_DEPS} ${CDEPS}
> > rm -f gdbserver
> >- ${CC-LD} $(GLOBAL_CFLAGS) $(LDFLAGS) -o gdbserver $(OBS) \
> >+ ${CC-LD} $(GLOBAL_CFLAGS) $(CFLAGS) $(LDFLAGS) -o gdbserver $(OBS) \
> > $(GDBSERVER_LIBS) $(XM_CLIBS)
> >
> > gdbreplay: gdbreplay.o
> > rm -f gdbreplay
> >- ${CC-LD} $(GLOBAL_CFLAGS) $(LDFLAGS) -o gdbreplay gdbreplay.o \
> >+ ${CC-LD} $(GLOBAL_CFLAGS) $(CFLAGS) $(LDFLAGS) -o gdbreplay
> >gdbreplay.o \
> > $(XM_CLIBS)
> >
> > # Put the proper machine-specific files first, so M-. on a machine
> >diff -Naurd old/src/tcl/unix/Makefile.in new/src/tcl/unix/Makefile.in
> >--- old/src/tcl/unix/Makefile.in 2003-01-21 14:40:18.000000000 -0500
> >+++ new/src/tcl/unix/Makefile.in 2004-04-07 15:05:09.046041896 -0500
> >@@ -477,7 +477,7 @@
> >
> >
> > tclsh: ${TCLSH_OBJS} ${TCL_LIB_FILE}
> >- ${CC} ${LDFLAGS} ${TCLSH_OBJS} @TCL_BUILD_LIB_SPEC@ ${LIBS} \
> >+ ${CC} ${CFLAGS} ${LDFLAGS} ${TCLSH_OBJS} @TCL_BUILD_LIB_SPEC@
> >${LIBS} \
> > ${CC_SEARCH_FLAGS} -o tclsh
> >
> > # Resetting the LIB_RUNTIME_DIR below is required so that
>
>
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer