This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[PING] Re: lib/gdb.exp patch not reviewed yet
- From: Joel Brobecker <brobecker at gnat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Wed, 28 Apr 2004 18:23:58 -0700
- Subject: [PING] Re: lib/gdb.exp patch not reviewed yet
- References: <20040401193104.GW888@gnat.com>
Ping?
Another alternative, short of being able to review this patch, would
be to back out the change responsible for the breakage. I would clearly
prefer that we fix this problem, but the patch has been waiting for
a review for almost 3 months...
> Would it be possible to review the patch posted by Michael C? It fixes
> a problem that has been hitting me regularly: Every so often, I end up
> using a set of sources that don't include the patch to gdb.exp (I was
> working in that file, and needed to produce diffs that don't include
> Michael's changes), and get bitten later down the road during the
> execution of the testsuite. The irony is that it happens only on the
> machines where it takes a lot of time to run the testsuite, so I ended
> up getting my results litteraly much later than originally anticipated.
>
> [rfa/testsuite/lib] get_compiler_info: two improvements
> http://sources.redhat.com/ml/gdb-patches/2004-02/msg00195.html
>
> 2004-02-09 Michael Chastain <mec.gnu@mindspring.com>
>
> * lib/compiler.c: Remove gcc_compiled, hp_cc_compiler,
> hp_aCC_compiler.
> * lib/compiler.cc: Likewise.
> * lib/gdb.exp (get_compiler_info): Eval lines only if they are
> 'set' commands. Log diagnostics for other lines. Set
> gcc_compiled, hp_cc_compiler, and hp_aCC_compiler.
>
> Thanks a lot,
--
Joel