This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] powerpc - extract a float return value


Kevin Buettner (kevinb@redhat.com):

> The rs6000 return value code will need to be revamped to not refer to
> DEPRECATED_REGISTER_BYTE.  And, in fact, it probably ought to be
> restructured to use the mechanisms found in ppc-linux.c.  See
> ppc_linux_return_value() and ppc_sysv_abi_return_value().  This
> is not a barrier to getting your current patch in; I only mention
> it in case you wish to tackle this bit of work too.

Sorry, I would not really easy for me, I do not have a convenient
setup for PPC (that is actually the reason why it took me 3 days
to be able to test against the testsuite :-)

> > I have not yet tested it against the testsuite, I will do that
> > tomorrow. In the meantime, if you have comments I would be happy to
> > address them!
> 
> Please let me know the results of your tests.  If they look good,
> please commit your patch.

OK, thanks. Tested on the ppc-elf simulator, on a x86-linux host.
No regression.

I have slightly modified the patch, I do not see any reason to have a special
case for doubles now. OK to apply with this change?

-- 
Jerome

Attachment: diff.3
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]