This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[obish] Remove redundant stack cycle tests
- From: Andrew Cagney <cagney at gnu dot org>
- To: gdb-patches at sources dot redhat dot com
- Date: Thu, 22 Apr 2004 13:50:40 -0400
- Subject: [obish] Remove redundant stack cycle tests
FYI,
The identical test is performed by the generic get_prev_frame_1.
committed,
Andrew
2004-04-22 Andrew Cagney <cagney@redhat.com>
* arm-tdep.c (arm_prologue_this_id): Delete redundant cycle test.
* m68hc11-tdep.c (m68hc11_frame_this_id): Ditto.
* m32r-tdep.c (m32r_frame_this_id): Ditto.
* frv-tdep.c (frv_frame_this_id): Ditto.
* avr-tdep.c (avr_frame_this_id): Ditto.
Index: arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.169
diff -u -r1.169 arm-tdep.c
--- arm-tdep.c 25 Mar 2004 16:52:42 -0000 1.169
+++ arm-tdep.c 22 Apr 2004 16:56:52 -0000
@@ -993,15 +993,6 @@
return;
id = frame_id_build (cache->prev_sp, func);
-
- /* Check that we're not going round in circles with the same frame
- ID (but avoid applying the test to sentinel frames which do go
- round in circles). */
- if (frame_relative_level (next_frame) >= 0
- && get_frame_type (next_frame) == NORMAL_FRAME
- && frame_id_eq (get_frame_id (next_frame), id))
- return;
-
*this_id = id;
}
Index: avr-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/avr-tdep.c,v
retrieving revision 1.78
diff -u -r1.78 avr-tdep.c
--- avr-tdep.c 16 Feb 2004 21:49:21 -0000 1.78
+++ avr-tdep.c 22 Apr 2004 16:56:54 -0000
@@ -966,16 +966,6 @@
return;
id = frame_id_build (base, func);
-
- /* Check that we're not going round in circles with the same frame
- ID (but avoid applying the test to sentinel frames which do go
- round in circles). Can't use frame_id_eq() as that doesn't yet
- compare the frame's PC value. */
- if (frame_relative_level (next_frame) >= 0
- && get_frame_type (next_frame) != DUMMY_FRAME
- && frame_id_eq (get_frame_id (next_frame), id))
- return;
-
(*this_id) = id;
}
Index: frv-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/frv-tdep.c,v
retrieving revision 1.81
diff -u -r1.81 frv-tdep.c
--- frv-tdep.c 6 Apr 2004 00:12:59 -0000 1.81
+++ frv-tdep.c 22 Apr 2004 16:56:56 -0000
@@ -1370,16 +1370,6 @@
return;
id = frame_id_build (base, func);
-
- /* Check that we're not going round in circles with the same frame
- ID (but avoid applying the test to sentinel frames which do go
- round in circles). Can't use frame_id_eq() as that doesn't yet
- compare the frame's PC value. */
- if (frame_relative_level (next_frame) >= 0
- && get_frame_type (next_frame) != DUMMY_FRAME
- && frame_id_eq (get_frame_id (next_frame), id))
- return;
-
(*this_id) = id;
}
Index: m32r-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/m32r-tdep.c,v
retrieving revision 1.25
diff -u -r1.25 m32r-tdep.c
--- m32r-tdep.c 16 Feb 2004 21:49:22 -0000 1.25
+++ m32r-tdep.c 22 Apr 2004 16:56:57 -0000
@@ -844,16 +844,6 @@
return;
id = frame_id_build (base, func);
-
- /* Check that we're not going round in circles with the same frame
- ID (but avoid applying the test to sentinel frames which do go
- round in circles). Can't use frame_id_eq() as that doesn't yet
- compare the frame's PC value. */
- if (frame_relative_level (next_frame) >= 0
- && get_frame_type (next_frame) != DUMMY_FRAME
- && frame_id_eq (get_frame_id (next_frame), id))
- return;
-
(*this_id) = id;
}
Index: m68hc11-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/m68hc11-tdep.c,v
retrieving revision 1.100
diff -u -r1.100 m68hc11-tdep.c
--- m68hc11-tdep.c 13 Mar 2004 14:51:55 -0000 1.100
+++ m68hc11-tdep.c 22 Apr 2004 16:56:58 -0000
@@ -899,16 +899,6 @@
return;
id = frame_id_build (base, func);
-#if 0
- /* Check that we're not going round in circles with the same frame
- ID (but avoid applying the test to sentinel frames which do go
- round in circles). Can't use frame_id_eq() as that doesn't yet
- compare the frame's PC value. */
- if (frame_relative_level (next_frame) >= 0
- && get_frame_type (next_frame) != DUMMY_FRAME
- && frame_id_eq (get_frame_id (next_frame), id))
- return;
-#endif
(*this_id) = id;
}