This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA/testsuite] get rid of gdb_suppress_entire_file in asm-source.exp
- From: Daniel Jacobowitz <drow at false dot org>
- To: Joel Brobecker <brobecker at gnat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 19 Apr 2004 13:36:31 -0400
- Subject: Re: [RFA/testsuite] get rid of gdb_suppress_entire_file in asm-source.exp
- References: <20040419172936.GY22414@gnat.com>
On Mon, Apr 19, 2004 at 10:29:36AM -0700, Joel Brobecker wrote:
> I noticed that this testcase is using gdb_suppress_entire_file, and
> I remember being told that this function was evil. So I suggest the
> following cleanup for this gdb.asm test:
>
> 2004-04-19 Joel Brobecker <brobecker@gnat.com>
>
> * gdb.asm/asm-source.exp: Remove use of gdb_suppress_entire_file.
>
> OK to apply?
In general, I agree, but this particular file is a can of worms.
Andrew likes the extremely noisy failure, to encourage people to port
the test to new targets. I'm not sure what I think about it; every
time I run into the issue I just do the port, so...
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer