Re: build failure due to observer.sh

[Andrew Cagney <cagney at gnu dot org>]

> Hello,
>
> The build failed on most of our machines, due to a problem happening
> during the sed command in observer.sh. Here is the output we got:
>
>         Creating observer.h-tmp
>         sed:     # Save original line for later processing into the actual parameter is not a recognized function.
>
> As a consequence, all observers are missing, and we fail during the link.
>
> I tried on AiX to remove the comments, to see if it works any better,
> and managed to get past this error. Are comments a GNU sed extension?

I don't think so, just sounds like it isn't a common extension, do the 
comments need to be in column one?  With the comments removed did it build?

> In my opinion, I would handle observer.sh the same as gdbarch.sh:
> The contributors run it manually when needed. And we keep and up-to-date
> version of observer.[hc] checked in the repository. That way, we avoid
> requiring a certain implementation of sed when just building GDB.

Having this built on-demand is one of the departures from gdbarch.sh 
(and why I committed this now, so early in a release cycle).  I'd like 
to see how unfixable the problem is before abandoning the idea.

> I can regenerate observer.[hc] and check them in, if you agree.

Lets first move the comments to outside of the sed line.  After that the 
SED can be simplified by using separate extracts for formal and actual. 
 If those fail, then yes, I guess we go back to generated observers.

Andrew