This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Rename i386_xxx_reg_to_regnum

From: Brian Ford <ford at vss dot fsi dot com>
To: Mark Kettenis <kettenis at chello dot nl>
Cc: jimb at redhat dot com, gdb-patches at sources dot redhat dot com
Date: Wed, 7 Apr 2004 15:06:47 -0500 (CDT)
Subject: [PATCH] Rename i386_xxx_reg_to_regnum
References: <8011-Fri02Apr2004094123+0300-eliz@gnu.org> <Pine dot GSO dot 4dot 58 dot 0404021000390 dot 21204 at thing1-200> <2719-Fri02Apr2004213907+0300-elizat gnu dot org> <Pine dot GSO dot 4 dot 58 dot 0404021648050 dot 21204 atthing1-200> <vt2ptam2gg1 dot fsf at zenia dot home><Pine.GSO.4.58.0404051748340.21204@thing1-200><200404062324.i36NOeA9001063@elgar.kettenis.dyndns.org>

On Wed, 7 Apr 2004, Mark Kettenis wrote:

> Brian Ford wrote:
>
>> I still propose we rename the _to_regnum functions, replacing
>> stabs and dwarf with dbx and svr4 to reduce confusion.  I'll be happy
>> to make a patch :-).
>
> Please do so.

Here is the semi-pre-approved rename patch.  I decided not to make any
style changes.

Jim, I hope you don't mind me putting words in your mouth, but I felt
your FIXME comment needed correction as a result of this, and the previous
change.

2004-04-07  Brian Ford  <ford@vss.fsi.com>

        * i386-tdep.c: Correct register numbering scheme comments throughout.
	(i386_stab_reg_to_regnum): Rename to i386_dbx_reg_to_regnum.
	(i386_dwarf_reg_to_regnum): Rename to i386_svr4_reg_to_regnum.
	(i386_elf_init_abi): Accomodate renames above.
	(i386_gdb_arch_init): Likewise.

-- 
Brian Ford
Senior Realtime Software Engineer
VITAL - Visual Simulation Systems
FlightSafety International
Phone: 314-551-8460
Fax:   314-551-8444

Attachment: i386-tdep.patch
Description: Text document

Follow-Ups:
- Re: [PATCH] Rename i386_xxx_reg_to_regnum
  - From: Jim Blandy

References:
- Re: [PATCH] i386_stab_reg_to_regnum (4 <-> 5, ebp <-> esp)
  - From: Eli Zaretskii
- Re: [PATCH] i386_stab_reg_to_regnum (4 <-> 5, ebp <-> esp)
  - From: Brian Ford
- Re: [PATCH] i386_stab_reg_to_regnum (4 <-> 5, ebp <-> esp)
  - From: Mark Kettenis

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]