This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] i386_stab_reg_to_regnum (4 <-> 5, ebp <-> esp)

On Wed, 7 Apr 2004, Mark Kettenis wrote:

> Brian Ford wrote:
>
>> I still propose we rename the _to_regnum functions, replacing
>> stabs and dwarf with dbx and svr4 to reduce confusion.  I'll be happy
>> to make a patch :-).
>
> Please do so.

Ok, I'm working this up and fixing all the misleading comments.  I do have
a stupid style question, though.  This bugs me:

if (a)
  return x;
else if (b)
  return y;
else
  return z;

Can that simply be:

if (a)
  return x;

if (b)
  return y;

return z;

?  I can't find any mention of this in the GNU coding standards.

Thanks.

-- 
Brian Ford
Senior Realtime Software Engineer
VITAL - Visual Simulation Systems
FlightSafety International
Phone: 314-551-8460
Fax:   314-551-8444
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]