This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [intercu] Handle simple DIEs pre-emptively


On Sun, Feb 22, 2004 at 08:03:16AM +0200, Eli Zaretskii wrote:
> > Date: Sat, 21 Feb 2004 20:01:17 -0500
> > From: Daniel Jacobowitz <drow@false.org>
> > +
> > +      /* This two-pass algorithm for processing partial symbols has a high
> > +	 cost in cache pressure.  Thus, handle some trivial cases here
> > +	 which cover the majority of C partial symbols.  DIEs which
> > +         neither have specification tags in them, nor could have specification
> > +         tags elsewhere pointing at them, can simply be processed and
> > +	 discarded.
> > +
> > +	 This segment is also optional; scan_partial_symbols and
> > +	 add_partial_symbol will handle these DIEs if we simply chain
> > +	 them in normally.  When compilers which do not emit large
> > +         quantities of duplicate debug information are more common,
> > +         this code can probably be removed.  */
> 
> More nit-picking: please use TABs and spaces consistently here.
> "M-x tabify" is your friend.

Actually, I blame Emacs for this one - when I justify (M-q) it plays
havoc with my tabbing, and is otherwise inconsistent.  This file could
use some serious tabification; I'll do it in a separate pass, later.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]