This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ob] Remove initializations of memset'd structure


On Tue, Feb 17, 2004 at 03:24:09PM -0500, Elena Zannoni wrote:
> I am not sure I follow your sentence. If you are worried that the
> value 0 can indicate a perfectly legal msymbol, this is no different
> from the situation we end up with when just using the memset. You can
> always add a new enum value of mst_bogus (pick your name) and use that
> in the terminating msym. BTW, there is almost identical code in
> minsyms.c:install_minimal_symbols.

Nothing important.  My only point was that anything which read the type
of this minimal symbol was already off the end of the array, because
mst_unknown does not act as a terminator; everything should either use
minimal_symbol_count (most things do), or SYMBOL_LINKAGE_NAME (msym) ==
NULL.  So there is no need for the type to be mst_unknown (or anything
else).

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]