This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: Avoid obstack_free in cp-namespace.c
- From: Eli Zaretskii <eliz at elta dot co dot il>
- To: Daniel Jacobowitz <drow at mvista dot com>
- Cc: carlton at kealia dot com,gdb-patches at sources dot redhat dot com
- Date: 10 Feb 2004 07:42:23 +0200
- Subject: Re: Avoid obstack_free in cp-namespace.c
- References: <20040209211010.GA25073@nevyn.them.org>
- Reply-to: Eli Zaretskii <eliz at elta dot co dot il>
> Date: Mon, 9 Feb 2004 16:10:10 -0500
> From: Daniel Jacobowitz <drow@mvista.com>
>
> - char *name_copy = obsavestring (name, len, &objfile->objfile_obstack);
> - struct symbol *sym = lookup_block_symbol (block, name_copy, NULL,
> - VAR_DOMAIN);
> + char *name_copy = alloca (len + 1);
> + struct symbol *sym;
> +
> + memcpy (name_copy, name, len);
> + name_copy[len] = '\0';
How large can the value of `len' be? I believe we have some coding
guidelines against using alloca for allocations that are too large.