Re: [patch/cp/testsuite] local.exp: update "ptype Local", is now "ptype l"

[Daniel Jacobowitz <drow at mvista dot com>]

On Sat, Jan 24, 2004 at 02:27:16AM -0500, Michael Chastain wrote:
> [Sorry David C, I sent this to "redha.com" the first time.]
> 
> This patch updates the "ptype Local" test in gdb.cp/local.exp.
> 
> First, I changed the test from "ptype Local" (a type) to
> "ptype l" (a variable of that type).  This gives more informative
> test output when gdb says that the type of "l" is "Foobar__fi.0::Local".
> "ptype Local" just complains about a nonexistent type, but
> "ptype l" outputs something specific that I can KFAIL on.

I would prefer that you not do this.  "ptype l" does give more
informative output, precisely because it is an easier problem to solve. 
By all means add the new "ptype l" test, but please don't remove the
existing "ptype Local" test.

> Also, overall, I really like my new way of writing these tests, with
> re_class, re_fields, re_methods, re_synth.  The new code is clear to me.
> But I dunno if it's clear to other people or just to me.  Thoughts?

I rather like it also.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer