This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Ping - PR1473


On Monday 05 January 2004 9:06 pm, Daniel Jacobowitz wrote:
> I don't like the idea of adding this test to keep_going.  This should
> only be necessary in the BPSTAT_WHAT_CHECK_SHLIBS case, correct?

Yes.

> Something like this:
>
> -         if (stop_on_solib_events)
> +         if (stop_on_solib_events || stop_stack_dummy)

Updated patch appended below, ok to apply?
Tested on i686-linux.

> I don't know if you need a stop_print_frame=0 also if
> (stop_stack_dummy).

This is already handled elsewhere.

Paul

2004-01-21  Paul Brook  <paul@codesourcery.com>

	* infrun.c (handle_inferior_event): Check stop_stack_dummy if handling
	BPSTAT_CHECK_WHAT_SHLIBS.

Index: infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.130
diff -u -p -r1.130 infrun.c
--- infrun.c	19 Jan 2004 17:28:52 -0000	1.130
+++ infrun.c	21 Jan 2004 13:18:11 -0000
@@ -2301,7 +2301,7 @@ process_event_stop_test:
 	     gdb of events.  This allows the user to get control
 	     and place breakpoints in initializer routines for
 	     dynamically loaded objects (among other things).  */
-	  if (stop_on_solib_events)
+	  if (stop_on_solib_events || stop_stack_dummy)
 	    {
 	      stop_stepping (ecs);
 	      return;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]