This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch/rfc] Give decr pc after break a default of zero
Date: Sat, 17 Jan 2004 10:36:51 -0500
From: Andrew Cagney <cagney@gnu.org>
> Removing the set-to-zero for Neutrino would be wrong; it is essential
> that we override the i386 default. Personally I think the "NOTE" form
> of the comment you added isn't really appropriate. I'd prefer
> something like:
>
> /* Neutrino rewinds to look more normal, so we have to override the
> i386 default value. */
>
> Since that explains why we override the i386 default value. It's
> probably a matter of taste, but I'd appreciate if you changes it that
> way.
I've changed it to:
``Neutrino rewinds to look more normal. Need to override the i386
default which is [unfortunatly] to decrement the PC.''
Make's it clear which is "wrong" :-) committed,
Thanks!
Mark