This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] irix5-nat.c: missing mips-tdep.h #include?
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Joel Brobecker <brobecker at gnat dot com>, gdb-patches at sources dot redhat dot com
- Date: Tue, 16 Dec 2003 11:16:58 -0700
- Subject: Re: [RFA] irix5-nat.c: missing mips-tdep.h #include?
- References: <20031216130021.A28132@gnat.com>
On Dec 16, 1:00pm, Joel Brobecker wrote:
> GDB has been broken for a while on IRIX, because the compiler could not
> find the definitions of mips_regsize() and mips_regnum(). This is
> causing the build to fail because the code that uses it in irix5-nat.c
> tries to deference the result. The compiler output is as follow:
>
> irix5-nat.c:58: warning: implicit declaration of function `mips_regsize'
> irix5-nat.c:64: warning: implicit declaration of function `mips_regnum'
> irix5-nat.c:64: invalid type argument of `->'
> irix5-nat.c:66: invalid type argument of `->'
> irix5-nat.c:68: invalid type argument of `->'
> irix5-nat.c:70: invalid type argument of `->'
> (etc...)
>
> I suggest the following change to fix this problem:
>
> 2003-12-16 J. Brobecker <brobecker@gnat.com>
>
> * irix5-nat.c: Include mips-tdep.h.
>
> OK to apply?
I think this can go in under the obvious fix rule.
Kevin